search

marklieberman / downloadstar

Download all items in a webpage that match a pattern
GNU General Public License v3.0
90 stars 16 forks source link

Long filenames prevent download #57

Open Kran1x opened 6 years ago

Kran1x commented 6 years ago

I'm trying to download files from a site which shortens filenames after approximately 55-60 characters, depending on their width, appending three full stops as an ellipsis afterwards. When using the ${text} variable, these shortened file names will silently not be downloaded if they come to contain any of these full stops, while any files with shorter names will. A workaround is using the limit filter so DS only reads until before the ellipsis, but if one forgets this, one may unknowingly miss any of these files with long names.

marklieberman commented 6 years ago

Probably the filename is too long or contains invalid characters and the call to downloads.download() is failing. There is no "download queue" interface at the moment, so there is nowhere to surface those types of errors and they are silently dropped.