search

marklogic-community / Corona

Community REST API for MarkLogic
Other
37 stars 9 forks source link

More detailed logging #56

Closed crichey closed 12 years ago

crichey commented 12 years ago

Please log POST parameters. Troubleshooting is much harder when I can't see what POST parameters the server is seeing.

ryangrimm commented 12 years ago

This might be best handled in the REST library (ml-rest-lib). I'll do some checking to see if logging POST vars can be turned on or if that would need to be implemented.

eedeebee commented 12 years ago

I wonder if this is more of an issue when you're writing a language client (like ActiveDocument) as opposed to an app directly on the REST apis.

crichey commented 12 years ago

I think that whenever you are dynamically generating the parameters you want the logging. I know what I think I'm sending URL encoded and I can put in some debugging to verify but I would be much more comfortable if the server told me what IT thinks I'm sending as that is what really

matters.

Clark Richey clark@clarkrichey.com

On 11/28/11 5:35 PM, "Eric Bloch" <reply+i-2374220-eddc723ba2671c364573facdee397a9c6936ac17-214112@reply.gith ub.com> wrote:

I wonder if this is more of an issue when you're writing a language client (like ActiveDocument) as opposed to an app directly on the REST apis.

Reply to this email directly or view it on GitHub: https://github.com/marklogic/Corona/issues/56#issuecomment-2908632

hunterhacker commented 12 years ago

We have a lot of language clients to write, so this will be good to help write them.

crichey commented 12 years ago

It would also be good to see the HTTP verb being reported for the request. yes, it is in the access log but having in consolidated would be good.

eedeebee commented 12 years ago

We just saw a case where this would have helped someone (Tom Hubschman) trying to make a PUT from java.

ryangrimm commented 12 years ago

Actually, in this case, the response contained all the info that would be required to debug ({"error":{"status":400,"code":"corona:INVALID-REQUEST","message":"Missing document body"}}), only the response body wasn't being printed out for failing requests.

That said, as a result I actually am about to commit a couple changes so every error is always logged.