marklogic-community / RunDMC

MarkLogic application for running a developer site
http://developer.marklogic.com/code/rundmc
Other
17 stars 18 forks source link

Common nav #758

Closed MukulAmbulgekar closed 6 years ago

MukulAmbulgekar commented 6 years ago

This PR includes following -

  1. Implements mega-nav header/footer for the docs app.
  2. Integrates Greg's refined mega-nav.xqy module.
  3. Fixes broken search regression on dmc-staging app (changes insrc/config/template.xhtml and src/css/screen.css )

Note that in src/lib/mega-nav.xqy, I have updated default-user-role and authenticated-user-role to dmc-user, as Dave confirmed in prod environment we use this role. If this role is not present in you dev env you may get error, please create this role or update mega-nav.xqy to admin, if you are using admin to deploy the dev app.

kcoleman-marklogic commented 6 years ago

I'm a little concered about the default-user-role and authenticated-user-role being set to a role that is not created by default when you deploy RunDMC. Would it make sense to add that to deployment configuration, or would we rather not?

dmcassel commented 6 years ago

The current default when deploying via Roxy is the admin user. Yes, it would be better to update the config to create the same user & role, then use that. That would be done in deploy/ml-config.xml.

MukulAmbulgekar commented 6 years ago

What about permissions for this role in the ml-config? Should I inherit from ${app-name}-role (I think this role is created by default when you deploy RunDMC app and it has insert/update permissions ) ? Or should I assign 'admin' role to the 'dmc-user' role ?

MukulAmbulgekar commented 6 years ago

Eduardo wants these changes to be deployed to the staging for review, I pushed updates to ml-config.xml to create 'dmc-user' while deploying the RunDMC.

@dmcassel as we discussed earlier, 'dmc-user' has admin role on the prod instance, so I kept the same in the ml-config as well. Let me know if you think, I should make any updates to the 'dmc-user' role config. Thanks.

dmcassel commented 6 years ago

Found a few minor code-cleanliness things to fix, otherwise looks good.