marklogic-community / RunDMC

MarkLogic application for running a developer site
http://developer.marklogic.com/code/rundmc
Other
17 stars 18 forks source link

#777: Update rewriter to redirect product notices properly #778

Closed kcoleman-marklogic closed 6 years ago

kcoleman-marklogic commented 6 years ago

This fix addresses the problem of http://docs.marklogic.com/copyright/legal not resolving to the proper content. However, it may or may not be a wise way to fix it. @dmcassel and @MukulAmbulgekar , if you have any thoughts on the subject, I'd love to hear them.

I chose to tweak the URL at the top because (a) the existing code isn't setup to expect it to be modified during the rewriter cascade in m:rewrite, and (b) I wanted the request to ultimately go through the normal request-for-PDF flow in case it changes in the future.

kcoleman-marklogic commented 6 years ago

Mukul pointed out I'm resolving the wrong URL, so back to the drawing board with that and your other suggestions. Thanks.

kcoleman-marklogic commented 6 years ago

OK, I've taken another crack at this. I basically implemented Dave's suggestion, with Mukul's correction to the origin URL. I did not change the "=" to "contains" because I'm not comfortable with that. It's a specific URL that is to be redirected.