search

marklogic-community / demo-cat

An application to help SEs find good demos and record bugs and RFEs on them. AngularJS talks to the MarkLogic database via the REST API.
Other
11 stars 17 forks source link

Fixed #256: revised search-ctrl init logic, allowed relative url in News section #257

Closed grtjn closed 8 years ago

grtjn commented 8 years ago

256

joemfb commented 8 years ago

Question: what are the customizations to ml-search-ng that require it to be checked in?

grtjn commented 8 years ago

There should be a comment in index.html. I considered upgrading to latest ml-search, but that requires angular 0.14. Is there a version if ml-search that works with 0.13?

joemfb commented 8 years ago

ml-search-ng@0.2.4 upgraded the angular dependency to ^1.4.1. I believe I did that for the update to the $q promise implementation (which provides API compat with the native Promise). Do you know if there's anything preventing demo-cat from upgrading angular?

grtjn commented 8 years ago

Nothing but proper testing? I'd prefer doing that separately though. I encourage you to open a ticket for it. I completely forgot about copying and patching ml-search. I think it was just for something small..