marklogic-community / marklogic-nifi-incubator

A collaboration space for processors, recipes, templates, etc. NOTE: improvements made to the connector in this project have been incorporated into the MarkLogic NiFi repository (https://github.com/marklogic/nifi).
Apache License 2.0
4 stars 11 forks source link

Issue 25 #65

Closed dmcassel closed 4 years ago

dmcassel commented 4 years ago

Thank you for submitting a contribution to marklogic-community/marklogic-nifi-incubator.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

For code changes:

The tests under nifi-marklogic-bundle weren't passing for me before starting this work; still aren't. Not sure whether I've got a configuration problem or something else.

N/A

N/A

N/A

For documentation related changes:

dmcassel commented 4 years ago

Worth noting in this PR -- the CLOSE_BATCH strategy requires running with just one NiFi task thread. Gary & I would welcome suggestions on getting away from that limitation.

garyvidal commented 4 years ago

Any progress on reviewing this, so we can move forward