search

marklogic-community / marklogic-samplestack

A sample implementation of the MarkLogic Reference Architecture
Apache License 2.0
82 stars 56 forks source link

Linux : gulp once fails #667

Closed gghai closed 9 years ago

gghai commented 9 years ago

gulp once --browser= +`` + +For *<browsername>*, you may supply one of "chrome", "firefox" or "ie". Please specify the name of a browser that you have already installed on your development machine,* for examplegulp once --browser=chrome`.

This case doesnt old true for linux as we dont have a GUI .

laurelnaiad commented 9 years ago

Is Samplestack intended to support development environments with no browser? How is anyone going to develop an app without having a browser?

gghai commented 9 years ago

gulp once also run the gulp e2e as part of it , as linux doesnt have the UI so the gulp once is failing ? Should we document to include sauce for linux only.

gghai commented 9 years ago

We should exclude gulp e2e from the gulp once task , that can make things better for all three operating system . Thoughts ?

gghai commented 9 years ago

Not able to proceed to test node tier on linux with this new change .

laurelnaiad commented 9 years ago

Part of the point of it is to validate that you are ready to develop it. I can't see how you're ready without a browser, but until we have formal clarification on that, I can make it possible to go without the browser and not get any errors messages. Does that sound ok?

gghai commented 9 years ago

if we just exclude gulp e2e from gulp once wont that solve the issue ?

gghai commented 9 years ago

This fix seems like have caused a regression where i am not able to run the gulp e2e tests on sauce environment . https://github.com/marklogic/marklogic-samplestack/issues/678

laurelnaiad commented 9 years ago

Ah, yes. Will fix.

laurelnaiad commented 9 years ago

That commit above is my fix for it. What do you want me to do with it?

gghai commented 9 years ago

pls check it in rC4. thx

gghai commented 9 years ago

Verified