marklogic-community / pipes

Pipes for MarkLogic DataHub is visual programming tool for MarkLogic Data Hub. It integrates with MarkLogic's Datahub and produces custom code step(s) using a no-code UI environment.
https://marklogic-community.github.io/pipes/
Other
13 stars 1 forks source link

As Pipes user I'd like to get more feedback from Pipes whether I have configured the blocks in my graph properly #126

Open josvanroosmalen opened 4 years ago

josvanroosmalen commented 4 years ago

In order to make Pipes more "dummy"/"fool" proof, I want to work on a sanity checker, and one of the first things is a sanity checker during editing the graphs, e.g. check that Feature/Lookup has a valid cts.query.

During editing we need need to be able to validate properties/widgets/etc. Preferable the callback should be able to return "false" and then the editor should not be closed, and we need to be able to provide feedback via alert.

This ticket is not about implementing sanity checks itself, but only the callbacks. so that we can build sanity checking on this.

sashamitrovich commented 4 years ago

@josvanroosmalen, can we rephrase this as: "As Pipes user I'd like to get more feedback from Pipes whether I have configured the blocks in my graph properly"? Is this correct?

josvanroosmalen commented 4 years ago

yes

danielholgate commented 4 years ago

There are two different editing mechanisms in Pipes.
One is the native litegraph property editing, which opens a small black box:

Screen Shot 2020-03-31 at 14 43 45

The second are the editing screens which open up for blocks (current only three) via double click and are actually a window in the Pipes application rather than litegraph:

Screen Shot 2020-03-31 at 14 45 24

Capturing the second type of dialog is easy because are already Pipes code and can be captured during/before/after edit. The first type of property editing requires adding hooks into the litegraph framework

Need to confirm which properties are targeted in this ticket

sashamitrovich commented 4 years ago

yes

Thanks, I changed the title.