marklogic-community / roxy

Deployment tool for MarkLogic applications. Also provides optional unit test and XQuery MVC structure
Other
87 stars 66 forks source link

Migrate Unit Testing issues and wikis to ml-unit-test #886

Open dmcassel opened 6 years ago

dmcassel commented 6 years ago

Roxy's Unit Test Framework has been segmented off to https://github.com/marklogic-community/ml-unit-test. In order to complete that process:

Question: should the unit testing code remain here in the Roxy repo? If it's removed, that will cause it to disappear from existing projects that upgrade. If it's left, we may be encouraging further drift.

grtjn commented 5 years ago

Has anyone tried applying ml-unit-test to a Roxy project? What does it entail? Is it backwards-compatible with the Roxy unit-testing stuff? If it is trivial to upgrade to ml-unit-test, then there is no real worry for drift..

dmcassel commented 5 years ago

There have been some bug fixes and improvements, specifically related to JSON handling.

I'm not aware of anyone having applied ml-unit-test to a Roxy project. The difference would be in deployment; usage is basically the same.

rhdunn commented 5 years ago

I have manually applied ml-unit-test to an existing project by copying the test files, not using the ml-gradle deployment or similar. Aside from working out where the files are (ml-unit-test-modules/src/main/ml-modules/root/test), the process has been straightforward, and haven't encountered any issues thus far.

Comparing the base ml-unit-test version (0.9.1) to the Roxy version, it is missing afaac5d71d1502f69d9cb44dd23401ff0c17aaa0 (#757 - return a 409 HTTP status code when there are test failures). Other than that, that version looks the same aside from formatting.

dmcassel commented 5 years ago

Just filed an issue to get that 409 enhancement into ml-unit-test.