Switch the xcc port to https if https is enabled.

marklogic-community / roxy

Deployment tool for MarkLogic applications. Also provides optional unit test and XQuery MVC structure

Other

87 stars 66 forks source link

Switch the xcc port to https if https is enabled. #891

Closed ciprianc closed 5 years ago

ciprianc commented 5 years ago

When building the url to talk to the xcc port roxy doesn't look whether that should be https or not, it's just hardcoded to http, which makes it impossible to deploy modules. This commit changes that by switching to https if either use-https-for-rest is set to true or ssl-certificate-template exists in the config.

First attempt at fixing #862

grtjn commented 5 years ago

Unfortunately I can't really test with https enabled easily, but it looks like the changes are made in the right places. I left a few suggestions inline though..

grtjn commented 5 years ago

I'll merge, so that our internal CI can run the self-test with it.