search

marklogic-community / slush-marklogic-node

Slush generator for a MarkLogic/node project
https://github.com/marklogic-community/slush-marklogic-node/wiki
Other
40 stars 28 forks source link

Cannot click x to clear search results #139

Closed grtjn closed 9 years ago

grtjn commented 9 years ago

I think I have reported this before, in demo-cat perhaps? Am I the only one bothered by this?

joemfb commented 9 years ago

This is in master?

grtjn commented 9 years ago

Yes, there is no dev branch..

hunterwilliams commented 9 years ago

This is because of bootstrap css but the fix should probably be in ML Search as it uses the bootstrap class by default and can override the style to fix it. I've created the issue here: https://github.com/joemfb/ml-search-ng/issues/72 and done the pull request on that project as well

joemfb commented 9 years ago

The fix has been merged, and will be automatically available as soon as I release v0.2.2 (which satisfies ~0.2.0). Nothing additional is needed here.

grtjn commented 9 years ago

@joemfb what can you tell about release 0.2.2 of ml-search-ng? (bonus points if you use milestones in future.. ;)

joemfb commented 9 years ago

I just pushed the release.

grtjn commented 9 years ago

0.2.2 works! vanilla slush app gives me this though:

bower                                  ECONFLICT Unable to find suitable version for ml-common-ng

I think we need to touch bower.json:

    "ml-common-ng": "~0.0.6",
    "ml-search-ng": "~0.2.0",
joemfb commented 9 years ago

I didn't know ml-common-ng was explicitly depend on here. No reason for that, just remove it. It's a dependency of ml-search-ng.

grtjn commented 9 years ago

Yep, that seems to work!