search

marklogic / entity-services

Data modeling and code scaffolding for data integration in MarkLogic
https://docs.marklogic.com/guide/entity-services
Apache License 2.0
7 stars 10 forks source link

Issues #351, #349. edits to version translator #353

Closed grechaw closed 7 years ago

grechaw commented 7 years ago

This commit contains a fix to version translation codegen from issue #351, as well as the small typo-ish fix to #349.
Unit tests are all good with this update. The change is a code cleanup too -- it looks a little bigger than it would otherwise, but theres a normalization in the generated code that makes it more readable and understandable IMO.

bsrikan commented 7 years ago

Looks good. Functional tests are all good too with updates to couple of keys for version translator fix for #349. examples and e2e also looking good. OK to merge.

bsrikan commented 7 years ago

Before you merge can you update where it sets $src-node to $source-node.

bsrikan commented 7 years ago

Maybe I spoke too soon.. It is ok as it is in your PR right.

grechaw commented 7 years ago

Actually, yes I wanted to have a unique name in that function call, though it is perhaps a cheat to name as i did.

bsrikan commented 7 years ago

OK to merge.

grechaw commented 7 years ago

Merged