search

marklogic / entity-services

Data modeling and code scaffolding for data integration in MarkLogic
https://docs.marklogic.com/guide/entity-services
Apache License 2.0
7 stars 10 forks source link

Json additional query #365

Closed grechaw closed 6 years ago

grechaw commented 6 years ago

This issue fix addresses search options generation. The currently-generated options only return XML instances, whereas the patched one returns json or xml instance data.

grechaw commented 6 years ago

At your leisure @bsrikan if you could take a glance at this change. I'll see if it affects any of the functional or e2e tests now.

bsrikan commented 6 years ago

Sure @grechaw Looks straight fwd to me. I see you have updated the expected result for search options. To test this though in my e2e I probably would have to include, in search-options, either "instance" to return json or "es:instance" to return xml right?

grechaw commented 6 years ago

That's right -- really this would have exposed a bug with search options + JSON, because the current additional-query element excludes JSON. In example code I edited the options file myself to return JSON, which was a cop-out.