Smartlogic adaptations for JenaDatabaseClient

marklogic / marklogic-jena

Adapter for using MarkLogic with the Jena RDF Framework

Other

5 stars 11 forks source link

Smartlogic adaptations for JenaDatabaseClient #34

Closed MichalWozniakSmartlogic closed 8 years ago

MichalWozniakSmartlogic commented 8 years ago

In this pull request we introduce two changes to JenaDatabaseClient that we found out necessary for our system. The changes have been tested as we use the forked version already in our system. Also, the changes preserve the current API of the client.

There changes are:

an option to turn off the timer-based flushing mechanism ("periodicFlush = false", we use this option in our system, the default remains "periodicFlush = true").
closing client transaction when currentTransaction.rollback() fails (abort() method)

grechaw commented 8 years ago

Hi @MichalWozniakSmartlogic making progress here. We need a signed agreement to include code from contributors. Here's a link to the CLA form http://developer.marklogic.com/products/cla I'm excited to have the chance for more collaboration here, so if you could get that form to MarkLogic, we'll move ahead rapidly. Thanks!

MichalWozniakSmartlogic commented 8 years ago

Hi Charles,

I'm sending the signed Contributor License Agreement in the response to your comment under the pull request: https://github.com/marklogic/marklogic-jena/pull/34

Best regards, Michal

From: Charles Greer notifications@github.com Sent: Friday, January 22, 2016 7:50 PM To: marklogic/marklogic-jena Cc: Michal Wozniak Subject: Re: [marklogic-jena] Smartlogic adaptations for JenaDatabaseClient (#34)

Hi @MichalWozniakSmartlogichttps://github.com/MichalWozniakSmartlogic making progress here. We need a signed agreement to include code from contributors. Here's a link to the CLA form http://developer.marklogic.com/products/cla I'm excited to have the chance for more collaboration here, so if you could get that form to MarkLogic, we'll move ahead rapidly. Thanks!

Reply to this email directly or view it on GitHubhttps://github.com/marklogic/marklogic-jena/pull/34#issuecomment-174010011.

grechaw commented 8 years ago

Thanks! I'll probably get to the merge then when I return from travelling next week.

grechaw commented 8 years ago

Hi @MichalWozniakSmartlogic , this PR has been merged into branch 1.0-develop, where we're continuing with jena 2 support.

I've ported the PR to jena-3, and expecting to push that later today. Once that's complete I'll close this PR

grechaw commented 8 years ago

OK, this PR has ben merged to 1.0-develop and develop.

MichalWozniakSmartlogic commented 8 years ago

Hello, thank you!

Best regards,

Michal

From: Charles Greer notifications@github.com Sent: Thursday, February 18, 2016 10:54 PM To: marklogic/marklogic-jena Cc: Michal Wozniak Subject: Re: [marklogic-jena] Smartlogic adaptations for JenaDatabaseClient (#34)

OK, this PR has ben merged to 1.0-develop and develop.

Reply to this email directly or view it on GitHubhttps://github.com/marklogic/marklogic-jena/pull/34#issuecomment-185938881.