Closed dmcassel closed 2 years ago
The develop branch has been updated so that this PR can be rebased on it.
Superceded by #149
Missed my chance to be a contributor! Thanks for pushing this over the line.
On Fri, Aug 26, 2022 at 11:04 AM Rob Rudin @.***> wrote:
Superceded by #149 https://github.com/marklogic/nifi/pull/149
— Reply to this email directly, view it on GitHub https://github.com/marklogic/nifi/pull/134#issuecomment-1228608089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLHUSJFSTUIADHL5UQ2QTV3DMGJANCNFSM54MOFOOA . You are receiving this because you authored the thread.Message ID: @.***>
-- 4V Services, LLC https://www.4vservices.com/ LinkedIn Profile https://www.linkedin.com/in/davidcassel/
Thank you for submitting a contribution to marklogic-community/marklogic-nifi-incubator.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
See https://github.com/marklogic/nifi/issues/125.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?
[ ] Is your initial contribution a single, squashed commit?
Not sure how to do that. Is that
For code changes:
This command failed for the latest dev branch due to "Too many files with unapproved license". Both
mvn clean install
andmvn -Dtest=ExecuteScriptMarkLogicIT test
pass.If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?N/AIf applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?N/AIf applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?