marklovers / kaplay

🦖 A JavaScript game library
https://kaplayjs.com
MIT License
230 stars 14 forks source link

fix: better timer start times #166

Open niceEli opened 2 weeks ago

niceEli commented 2 weeks ago

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes if needed, a note on the devices and browsers this has been tested on.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

mflerackers commented 1 week ago

Now there is one frame before action is called, no? Because when you do wait(0, action), action won't be called until the next update. I think that is what the comment was referring to.

mflerackers commented 1 week ago

Is the action still called?

niceEli commented 1 week ago

yes

pkg-pr-new[bot] commented 1 week ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 550082d

kaplay

``` npm i https://pkg.pr.new/marklovers/kaplay@166 ```


templates

- [default](https://pkg.pr.new/template/bdf138f2-8831-480c-9a30-09fa34fcd51b)