Bower install fails - Githubissues

markmarijnissen / cordova-app-loader

Remote update your Cordova app

http://data.madebymark.nl/cordova-app-loader/index.html

645 stars 128 forks source link

Bower install fails #2

Closed n9986 closed 10 years ago

n9986 commented 10 years ago

Tried doing this, but alas:

$   bower install cordova-app-loader cordova-promise-fs bluebird

bower not-cached    git://github.com/petkaantonov/bluebird.git#*
bower resolve       git://github.com/petkaantonov/bluebird.git#*
bower cached        git://github.com/ftlabs/fastclick.git#1.0.3
bower validate      1.0.3 against git://github.com/ftlabs/fastclick.git#>=1.0.3
bower download      https://github.com/petkaantonov/bluebird/archive/v2.3.11.tar.gz
bower progress      bluebird#* received 0.2MB
bower progress      bluebird#* received 0.2MB
bower progress      bluebird#* received 0.2MB
bower progress      bluebird#* received 0.3MB
bower ENOTFOUND     Package cordova-app-loader not found

lylepratt commented 10 years ago

To add to the above: Its also really difficult to understand what exactly is required to run this loader. Is bluebird absolutely required? What depends on it? Is cordova-promise-fs absolutely required or can you use normal Cordova FileSystem stuff? Basically....some clean up is in order.

markmarijnissen commented 10 years ago

I have updated the readme. Is it clear why all files are needed now?

Basically:

CordovAppLoader.js includes CordovaFileCache to cache a files from a server.
CordovaFileCache uses CordovaPromiseFS.js to simplify using the Cordova File API.
CordovaPromiseFS.js needs a Promise library. (It does not include one so the developer can use his/her favorite Promise library)
You can't update bootstrap.js, so it needs to be a minimal, reliable scriptloader.

I could include CordovaPromiseFS.js in the CordovaAppLoader.js build, like I did with the CordovaFileCache. It's on my todo.

markmarijnissen commented 10 years ago

Bower should work now! Can you confirm? Then I'll close this issue.