markmarkoh / datamaps

Customizable SVG map visualizations for the web in a single Javascript file using D3.js
http://datamaps.github.io
MIT License
3.78k stars 1.01k forks source link

bubblesConfig getting ignored? #70

Closed billyroh closed 10 years ago

billyroh commented 10 years ago

I've set a custom values for borderWidth and borderColor for my bubbles, but my inputs seem to be getting ignored. Is there something I'm missing?

Example: http://pblc.gd/map/

  bubblesConfig: {
    borderWidth: 0,
    borderColor: '#000',
    popupOnHover: true,
    popupTemplate: function(geography, data) {
      return '<div class="hoverinfo"><strong>' + data.name + '</strong></div>';
    },
    fillOpacity: 0.75,
    animate: true,
    highlightOnHover: true,
    highlightFillColor: '#FC8D59',
    highlightBorderColor: 'rgba(250, 15, 160, 0.2)',
    highlightBorderWidth: 2,
    highlightFillOpacity: 0.85,
    exitDelay: 100
  },
markmarkoh commented 10 years ago

Sorry, let this one slip through the cracks and haven't responded.

Move all the custom values to the actual call to bubbles, like where you updated the popupTemplate function.

jacoblyles commented 10 years ago

this is still a problem for me using the worldsmap download linked to in the readme

markmarkoh commented 10 years ago

Can you post the code you are using?

You shouldn't be setting bubbleConfig when you create a new map. It should be a parameter to bubbles.

On Thursday, April 24, 2014, Jacob Lyles notifications@github.com wrote:

this is still a problem for me using the worldsmap download linked to in the readme

— Reply to this email directly or view it on GitHubhttps://github.com/markmarkoh/datamaps/issues/70#issuecomment-41340956 .

Mark DiMarco Phone: 512.745.6267 Email: mark.dimarco@gmail.com

jacoblyles commented 10 years ago

Oh, then it works as planned. Thanks!