feat: DocumentType (_type) has been deprecated in ElasticSearch 7

markmcdowell / NLog.Targets.ElasticSearch

NLog target for Elasticsearch

MIT License

176 stars 89 forks source link

feat: DocumentType (_type) has been deprecated in ElasticSearch 7 #124

Closed snakefoot closed 4 years ago

snakefoot commented 4 years ago

Trying to resolve #123 by not having DocumentType as required (can be blank).

https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html

Also improved the ability for getting debug-output into NLog InternalLogger (When enabled)

Also change the default-value from "logevent" to "_doc" as it seems to work better (also for Serilog)

Checklist

[x] My commits follow Conventional Commits
[ ] documentation is updated

ghost commented 4 years ago

There were the following issues with this Pull Request

Commit: 9a421ba4aa59419d50dd57c6d4eed86b91269d73
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

snakefoot commented 4 years ago

When this PR has been merged, then I also think a small fix can be made, so one can use NLog JsonLayout directly (or another Json-related-Layout like EcsLayout)

snakefoot commented 4 years ago

Thanks for the merge. Have now created #125 as mentioned.