search

markmcdowell / NLog.Targets.ElasticSearch

NLog target for Elasticsearch
MIT License
176 stars 89 forks source link

Exception logging #127

Closed RobinPeensVelocity closed 4 years ago

RobinPeensVelocity commented 4 years ago

Found an issue where certain fields on Exceptions cause NLog internal exceptions and never make it to elastic as a result... I have proposed a solution on the following PR : https://github.com/markmcdowell/NLog.Targets.ElasticSearch/pull/126

2020-06-10 15:35:53.7916 Warn Error serializing exception property 'ScopeId', property ignored Exception: Newtonsoft.Json.JsonSerializationException: Error getting value from 'ScopeId' on 'System.Net.IPAddress'. ---> System.Net.Sockets.SocketException: The attempted operation is not supported for the type of object referenced at System.Net.IPAddress.get_ScopeId() at lambda_method(Closure , Object ) at Newtonsoft.Json.Serialization.ExpressionValueProvider.GetValue(Object target) --- End of inner exception stack trace --- at Newtonsoft.Json.Serialization.ExpressionValueProvider.GetValue(Object target) at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.CalculatePropertyValues(JsonWriter writer, Object value, JsonContainerContract contract, JsonProperty member, JsonProperty property, JsonContract& memberContract, Object& memberValue) at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeObject(JsonWriter writer, Object value, JsonObjectContract contract, JsonProperty member, JsonContainerContract collectionContract, JsonProperty containerProperty)

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

RobinPeensVelocity commented 4 years ago

That's great and more configurable thanks