search

markmcdowell / NLog.Targets.ElasticSearch

NLog target for Elasticsearch
MIT License
176 stars 89 forks source link

Client Bulk Sync --> Async #140

Closed Msuphi closed 3 years ago

Msuphi commented 3 years ago

Hi, Why did we not do it asynchronously, is there a specific reason? Wouldn't it cause slowness when something like BufferSize = 250 ?

var result = _client.Bulk(payload); --> var result = _client.BulkAsync(payload);

Thanks ..

snakefoot commented 3 years ago

Why did we not do it asynchronously, is there a specific reason?

Think it is because NLog AsyncTaskTarget is somewhat new (introduced with NLog 4.6).

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.