markmcdowell / NLog.Targets.ElasticSearch

NLog target for Elasticsearch
MIT License
176 stars 89 forks source link

Upgrade to dotnet 5 #145

Closed qcerasmus closed 3 years ago

qcerasmus commented 3 years ago

I have upgraded the project to dotnet5. This did unfortunately have breaking changes so I fixed those as well.

snakefoot commented 3 years ago

Think the problem you see with "breadking" changes, is caused by you "upgrading" to NLog 5.0-beta.

You should stay away from NLog 5.0-beta/prerelease, since they were early attempts to support NetCore. But then Microsoft introduced NetStandard2 and then NLog 4.5 could be made. See also "What happend to NLog 5?" https://nlog-project.org/2017/12/20/nlog-4-5-is-near.html

https://www.nuget.org/packages/NLog.Targets.ElasticSearch ver. 7.5.0 works just fine with Net50.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.