Feature - Add GitHub star count

markmead / hyperui

Free Tailwind CSS components for application UI, ecommerce and marketing with support for dark mode, RTL and Alpine JS 🚀

https://hyperui.dev

MIT License

9.69k stars 378 forks source link

Closed prajjwalyd closed 11 months ago

prajjwalyd commented 11 months ago

Add the star count to the header.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
hyperui	✅ Ready (Inspect)	Visit Preview	Oct 13, 2023 10:23am

markmead commented 11 months ago

Looks good! Gonna pull it down and make some changes as there's a few things I'm not sure on.

markmead commented 11 months ago

OK so a few changes:

You're right, the 6.4K style looks way better than 6412
It doesn't look like we need storage, the API is only hit once (Magic of Next JS I guess 🤷‍♀️)

I made a new component as I didn't like the approach of adding logic to the GithubIcon component.

Let me know what you think!

prajjwalyd commented 11 months ago

Yes, the 6.4K style looks much better and it will not create a problem in the future when the count will increase.
I was not aware of this next.js feature 😅
The separate component looks cleaner!

I think we're good to go!