markmead / hyperui

Free Tailwind CSS components for application UI, ecommerce and marketing with support for dark mode, RTL and Alpine JS 🚀
https://hyperui.dev
MIT License
9.69k stars 378 forks source link

Feature - New blog card component #415

Closed Justin-Bento closed 10 months ago

Justin-Bento commented 10 months ago

A simple and versatile Blog Card component to enhance your projects. This component includes a light and dark version not only beautifully displays blog information but also includes a direct link for seamless navigation. Check out the latest addition to our codebase!

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hyperui ✅ Ready (Inspect) Visit Preview Nov 25, 2023 3:57pm
markmead commented 10 months ago

This component includes a light and dark version not only beautifully displays blog information but also includes a direct link for seamless navigation. Check out the latest addition to our codebase!

Do you work in the M&S marketing department?

Justin-Bento commented 10 months ago

Sure thing. I'll change colours and feedback later today.

Justin-Bento commented 10 months ago

This component includes a light and dark version not only beautifully displays blog information but also includes a direct link for seamless navigation. Check out the latest addition to our codebase!

Do you work in the M&S marketing department?

Nah, I used ChatGPT 😅. But forgot to proofread the description I'm looking at it and it's too much. 😂

Justin-Bento commented 10 months ago

@markmead I've updated the code based on your feedback.

Let me know what you think of this code.

markmead commented 10 months ago

Thanks for working on these changes @Justin-Bento! It looks like changes were done to the *-dark.html component, can they be done on the *.html component please? Also, I only meant change to "Lorem ipsum..." for the description, the title and button text can stay as they were!

Justin-Bento commented 10 months ago

I've added the changes @markmead

markmead commented 10 months ago

Comments haven't been addressed. Please look through them again.

markmead commented 10 months ago

Sorry for spamming you but this is my first time working on a project. Can you show me what you see on your end and I'll show you my version as it seems to be updated on my end.

Looks like it might just be the link at the bottom that still needs addressing. If you do that and updated the dark mode component to include both the dark mode and light mode classes, then I can re-review.

markmead commented 10 months ago

You've still not resolved the issue with the link. It's the third time I've mentioned this so I'm closing the PR.