search

markmead / hyperui

Free Tailwind CSS components for application UI, ecommerce and marketing with support for dark mode, RTL and Alpine JS 🚀
https://hyperui.dev
MIT License
8.86k stars 341 forks source link

Feature - Added a new component under header #463

Closed R1shabh-Gupta closed 1 month ago

R1shabh-Gupta commented 1 month ago

Description

This pull request adds a new navbar component with integrated search functionality, as discussed in issue #462.

Screenshots

Screenshot 2024-05-17 at 11 44 23 PM Screenshot 2024-05-17 at 11 44 35 PM

Related Issue

Fixes #462

Checklist

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hyperui ✅ Ready (Inspect) Visit Preview May 17, 2024 6:17pm
markmead commented 1 month ago

Is this not just copied from another Tailwind CSS component library? There's stuff in there like data-state="closed" which makes no sense and even seen the word "Radix" in the code 🤦‍♀️

Not confident this is your own code and therefore I'm not looking to have this merged.

You've even left dark: classes in the light component which is lazy.

R1shabh-Gupta commented 1 month ago

I apologize for the mistake. I was working on my portfolio where I used code from the ShadCN library for functional buttons on the navbar, and I mistakenly copied that code directly into this project. I understand that this is not acceptable, and I appreciate you pointing out the issues.

This is my first time contributing to an open-source project. To correct this, I will recreate the navbar component from scratch. I will make sure that all class names are consistent and relevant to the project.

Regarding the comment about the dark classes in the light component: I thought that different files for dark and light themes were for different renderings, and therefore I kept the code the same. I now realize that I should have followed the project's examples more closely.