markmfredrickson / optmatch

Functions for optimal matching in R
https://markmfredrickson.github.io/optmatch
Other
47 stars 14 forks source link

update `summary.optmatch`'s matched.distances handling #106

Closed benthestatistician closed 5 years ago

benthestatistician commented 8 years ago
  1. Check for "matched.distances" attribute, and when not found just omit this aspect of report.
  2. Add a new argument "xbal.control", or something along those lines, either NULL (default) or a list of arguments to be passed to xBalance. (Replacing what's currently in the ...)
  3. Remove "propensity.model" argument. Instead, accept fitted models and other things in the ... slot.
  4. For any object passed as a ..., attempt to return a summary of the matched distances such as the one currently being returned. Do this by applying match_on to the object, then matched.distances to whatever comes out of that. Note that this may result in multiple summaries of matched distances.
  5. For any object passed as a ... that is also a glm, return balance info. Note that this may result in multiple balance summaries, or none.

Rationale: In light of #57, summary.optmatch should not necessarily expect optmatch objects to carry a "matched.distances" attribute. On the other hand, there are situations when the summary should include matched distances information regarding distances other than the distance actually used to produce the match. In particular, the usage summary(my_match, my_PS_model) ought to be returning distances on the score inside of my_PS_model.

josherrickson commented 8 years ago

Closed by mistake. 1. is complete. Remainder is open.

benthestatistician commented 5 years ago

The parts of this that aren't done are out of date.