search

markmfredrickson / optmatch

Functions for optimal matching in R
https://markmfredrickson.github.io/optmatch
Other
47 stars 14 forks source link

Partial matches #117

Closed JanMarvin closed 8 years ago

JanMarvin commented 8 years ago

Hey, without the changes optmatch creates warnings if used in combination with options(warnPartialMatchDollar = TRUE)

Since R's default is to not warn this is not of high importance.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.06%) to 66.465% when pulling 20ab728a9901a9e5adc523b4e6962154b20e9a19 on JanMarvin:warnPartialMatchDollar into 90127afd7ec8bdfd26a174800b28b1045edc00ac on markmfredrickson:master.

benthestatistician commented 8 years ago

Looks good to me! Thanks for the suggestion, @JanMarvin .

I'm pretty sure I'm the one responsible for this code, in particular for its use of partial matching, so I'm going to go ahead had accept the pull request. Feel free to chime and/or adjust as you see fit, though, @markmfredrickson and @josherrickson .