markmfredrickson / optmatch

Functions for optimal matching in R
https://markmfredrickson.github.io/optmatch
Other
47 stars 14 forks source link

caliper= argument sometimes respected, other times silently ignored #198

Open benthestatistician opened 3 years ago

benthestatistician commented 3 years ago

Most fullmatch() and pairmatch() methods call match_on() on their first arguments, in the process consulting any caliper= arguments (or within= arguments, ...) that were given to the full()/pair() call. But neither fullmatch.matrix() nor pairmatch.matrix() does this, with the result that caliper= arguments are silently ignored. Confusing and likely to induce errors.

We currently address this issue as it pertains to within= arguments -- in the case of fullmatch(), here -- and we might do something similar for caliper. (It will require a tad more effort, however, because any caliper= specifications would be hiding in the ....)