markmfredrickson / optmatch

Functions for optimal matching in R
https://markmfredrickson.github.io/optmatch
Other
47 stars 14 forks source link

error identifying infeasible problems #92

Closed benthestatistician closed 9 years ago

benthestatistician commented 9 years ago

At the beginning of .fullmatch.with.recovery, decision as to whether to trigger recovery is based on whether

(mxctl.r * dim(d.r)[1] >= prod(dim(d.r)[2], omf.r, na.rm=TRUE)

is TRUE. I think the criterion should instead be

(mxctl.r * dim(d.r)[1] >= prod(dim(d.r)[2], 1-omf.r, na.rm=TRUE)
josherrickson commented 9 years ago

Fixed in 59085225.