markniu / Bed_Distance_sensor

Auto bed level with High resolution distance sensor
281 stars 28 forks source link

Uninstall doesn't revert changes to `scripts/buildcommands.py` #122

Closed dhoard closed 6 months ago

dhoard commented 7 months ago

When performing an uninstall, the change to scripts/buildcommands.pymade during installation...

sed 's/--dirty//g' "${HOME_DIR}/scripts/buildcommands.py" -i

... isn't reverted

markniu commented 7 months ago

you can run this in the folder klipper to reset. git reset --hard

dhoard commented 6 months ago

@markniu I'm curious why you closed the issue without actually fixing it.

You provided a workaround, which is great, but the core issue still remains in the uninstall script.

markniu commented 6 months ago

thanks, I just updated the uninstall.sh file for the buildcommands.py file recovery