marko-cerovac / material.nvim

:trident: Material colorscheme for NeoVim written in Lua with built-in support for native LSP, TreeSitter and many more plugins
GNU General Public License v2.0
968 stars 124 forks source link

enabling mini in plugins table causes mini.indentscope highlight thingy to not be visible (repro included) #208

Closed beaumccartney closed 1 month ago

beaumccartney commented 1 month ago

repro:

-- Clone 'mini.nvim' manually in a way that it gets managed by 'mini.deps'
local path_package = vim.fn.stdpath("data") .. "/site/"
local mini_path = path_package .. "pack/deps/start/mini.nvim"
if not vim.loop.fs_stat(mini_path) then
    vim.cmd('echo "Installing `mini.nvim`" | redraw')
    local clone_cmd = {
        "git",
        "clone",
        "--filter=blob:none",
        "https://github.com/echasnovski/mini.nvim",
        mini_path,
    }
    vim.fn.system(clone_cmd)
    vim.cmd("packadd mini.nvim | helptags ALL")
    vim.cmd('echo "Installed `mini.nvim`" | redraw')
end

-- Set up 'mini.deps' (customize to your liking)
require("mini.deps").setup({ path = { package = path_package } })

local add, now, later = MiniDeps.add, MiniDeps.now, MiniDeps.later

add("marko-cerovac/material.nvim")
require("material").setup({
    plugins = {
        -- XXX: comment this out to see scope highlighting
        "mini",
    },
})

require("mini.indentscope").setup()

vim.cmd"colorscheme material"
marko-cerovac commented 1 month ago

Can you switch the last two lines, so that the colorscheme material call is executed before require('mini.indentscope').setup() and let me know the results. Also, can you please try commenting out "mini" in the material setup function and let me know if the indent line shows then because I can't reproduce this error.

beaumccartney commented 1 month ago

I can no longer reproduce the issue either, with either ordering of the colorscheme and indentscope call - apologies (on a fresh laptop, perhaps the issue had to do with that). I'll close the issue cause I can't reproduce anymore.

On this working setup I find the markup very difficult to see with the mini colors enabled.

First screenshot is with mini enabled in the material setup, second screenshot is when I comment it out.

image image

Ig if possible I'd prefer the color be bright like in the second screenshot, but that's a design decision.

marko-cerovac commented 1 month ago

Yeah, that's intentional. If you want, you can always override the color in your config. You just need to modify the highlight group MiniIndentScopeSymbol.