search

marko-js-archive / marko-loader

DEPRECATED: see https://github.com/marko-js/webpack
MIT License
10 stars 12 forks source link

Add Webpack 2 config syntax support #11

Closed larixer closed 7 years ago

larixer commented 7 years ago

Hi Guys,

I have tried to submit minimal change set to add support for Webpack 2 config syntax. With these changes both Webpack 1 syntax and Webpack 2 syntax should be supported. I have tested this on vanilla marko-webpack example and marko-webpack example upgraded to Webpack 2 syntax.

larixer commented 7 years ago

@mlrawlings Michael, could you review this PR, thank you!

mlrawlings commented 7 years ago

@vlasenko Are you thinking this removes the need for #5?

larixer commented 7 years ago

@mlrawlings Yes, I think the approach in this PR is evolutionary. https://github.com/marko-js/marko-loader/pull/5 is more radical and I have doubts that it is needed right now, perhaps something like this might be needed in the future if difficult problems will be found in evolutionary approach.

austinkelleher commented 7 years ago

Thanks for the PR! This looks to be resolved in https://github.com/marko-js/marko-loader/pull/14. I'm going to close this for now. Please let me know if you're still seeing issues.