marko-js-archive / marko-loader

DEPRECATED: see https://github.com/marko-js/webpack
MIT License
10 stars 12 forks source link

Remove option target = server, use target=node on Webpack instead #18

Closed jasonmacdonald closed 7 years ago

jasonmacdonald commented 7 years ago

I've very confused about the option target=server for Marko-loader. For a server side build, wouldn't using Webpacks target of node make more sense as to the intention of building for server-side?

If the desire is to leave this option as is, it should really be documented that you need to set it on the loader options. The only way to discover this currently is to go through the code after webpack blows up about trying to use VDOM on the server.

If you would like to change it, I'm more than happy to submit a PR.