marko-js-archive / marko-loader

DEPRECATED: see https://github.com/marko-js/webpack
MIT License
10 stars 12 forks source link

Critical dependency: the request of a dependency is an expression #27

Open MiloCasagrande opened 5 years ago

MiloCasagrande commented 5 years ago

After upgrading from 1.3.3 to 1.5.0, using marko-loader with webpack, I get the following error:

Critical dependency: the request of a dependency is an expression

I can reproduce the same issue using the marko-webpack repository after upgrading all dependencies in there.

This is the output taken from the marko-webpack repository when running npm start:

WARNING in ./src/components/app-tabs/index.marko 1:0-18
Critical dependency: the request of a dependency is an expression
 @ ./src/components/app/index.marko
 @ ./src/pages/home/client.js

When loading the app from a brwoser, the app itself is "broken": no CSS and no interactivity. This is the error I get from the browser console:

Uncaught Error: Cannot find module 'undefined'

Dependencies:

sqrter commented 5 years ago

+1

jesse1983 commented 5 years ago

+1

eltimn commented 5 years ago

We're seeing this problem as well. We narrowed it down to the 1.4.0 release.

arthurchenn commented 5 years ago

Same problem here, last working version is 1.3.3. Will it ever be fixed?

Dependencies:

marko 4.18.25
marko-loader 1.5.0
webpack 4.41.2