marko-js-archive / marko-widgets

[LEGACY] Module to support binding of behavior to rendered UI components rendered on the server or client
http://v3.markojs.com/docs/marko-widgets/
MIT License
141 stars 40 forks source link

Replacing falsey check from this.shouldUpdate #123

Closed jpattishall closed 8 years ago

jpattishall commented 8 years ago

The documentation states that returning false from this.shouldUpdate will prevent the view from being updated.

However, this check is falsey, and will not update for falsey values as well. PR for consistency.

patrick-steele-idem commented 8 years ago

Thanks for the fix @jpattishall ! New version published: marko-widgets@5.3.3