search

marko-js-archive / marko-widgets

[LEGACY] Module to support binding of behavior to rendered UI components rendered on the server or client
http://v3.markojs.com/docs/marko-widgets/
MIT License
142 stars 40 forks source link

bump to 6.2.0 #143

Closed scttdavs closed 8 years ago

scttdavs commented 8 years ago

Updates listener-tracker to use v1.1 which adds functionality to subscribeTo to work with non-instances of EventEmitter, such as window:

init() {
    this.subscribeTo(window).on('resize', this.onResize);
}
mlrawlings commented 8 years ago

Hey @scttdavs,

Thanks, for the update to listener-tracker! It's very much appreciated. However, since we're using a caret range on the listener-tracker dependency, 1.1 (and any version up to 2.0) will already be pulled in on npm install.

I know this in a way adds a new feature, but seeing as a new install will already be pulling in the latest version of listener-tracker (even back to the 1.x branch of marko-widgets), I don't think it makes sense to bump the version here.

scttdavs commented 8 years ago

cool, just wanted to be able to pull the changes in so I opened this before I forgot about it, but sounds like it's good already, thx 👍