Closed patrick-steele-idem closed 7 years ago
Would there be any proposed changes to defineRenderer
and defineWidget
in this case? Are you looking to phase those out?
@yomed
Would there be any proposed changes to defineRenderer and defineWidget in this case? Are you looking to phase those out?
To keep things simple I didn't want to go into the split renderer case, but we would also like to simplify that as well by removing the calls to defineRenderer
and defineWidget
:
src/components/my-component/
renderer.js
module.exports = {
getTemplateData: function(state) { ... },
...
};
widget.js
module.exports = {
handleFooClick: function() { ... },
...
};
index.marko
<div w-bind>
...
</div>
I would very much look forward to this change.
Ah, this looks amazing!
Also:
module.exports = {
getTemplateData: function(state) { ... },
...
};
Not?:
export default {
getTemplateData: function(state) { ... },
...
};
@basickarl You are free to use ES6 (you'll need to use babel on both the server and the browser if you use import
/export
though). We plan on allowing the following as well:
export default class {
handleFooClick() { ... }
handleBarClick() { ... }
...
};
The only good reason to use class
is that you don't have to worry about comma separators, which is kind of nice.
Closing this issue in favor of the issue created on the marko
repo: https://github.com/marko-js/marko/issues/416
Current setup:
src/components/my-component/
index.js
template.marko
Proposed solution
The above setup is not bad, but there is some boilerplate that we would like to remove by making the following changes:
index.js
→component.js
template.marko
→index.marko
(the template becomes the entry point)require('marko-widgets').defineComponent(...)
template: require('./template.marko')
Marko Widgets will detect that the template is the entry point and compile the template differently such that it no longer exports a
Template
instance, but rather it will be a module that exports two methods:render(input)
- Allows the UI component be rendered via a JavaScript API (e.g.,require('my-component').render({ name: 'Frank' }).appendTo(document.body);
)renderer(input, out)
- Used by the custom tag rendererThe previous setup would now be simplified as shown below:
src/components/my-component/
component.js
index.marko
Additional thoughts
Future improvements
By making the template the entry point, we can do a lot more things that were not previously possible. This is because we have full control over how a Marko template is compiled while we don't have control how the user writes the JavaScript code.
Single file component
We could easily support inlining the JavaScript code for the component into the template as shown below:
No references to
marko-widgets
With the new setup, there are no references to the
marko-widgets
module when building a UI component. This is a good thing since it makes it easier to merge Marko Widgets functionality into the coremarko
package (future proposal).Backwards compatibility
We intend to maintain backwards compatibility. Developers could start to use the new, simplified setup, but old code would continue to work.
Related proposals