search

marko-js / atom-language-marko

Syntax highlighting in Atom for the Marko templating language
MIT License
33 stars 6 forks source link

latest language-marko throws errors while editing #11

Closed smulder closed 3 years ago

smulder commented 7 years ago

[Enter steps to reproduce below:]

  1. After latest language-marko update typing any time in a template file will throw an error (see below)
  2. ...

Atom Version: 1.12.2 Electron Version: 1.3.6 System: Mac OS X 10.12 Thrown From: language-marko package, v2.0.10

Stack Trace

Uncaught TypeError: markoUtil.loadMarkoCompiler(...).buildTaglibLookup is not a function

At /Users/scott/.atom/packages/language-marko/src/autocomplete/SuggestionsBuilder.js:190

TypeError: markoUtil.loadMarkoCompiler(...).buildTaglibLookup is not a function
    at SuggestionsBuilder.get taglibLookup [as taglibLookup] (/Users/scott/.atom/packages/language-marko/src/autocomplete/SuggestionsBuilder.js:190:82)
    at SuggestionsBuilder.addAttributeValueSuggestions (/Users/scott/.atom/packages/language-marko/src/autocomplete/SuggestionsBuilder.js:339:13)
    at SuggestionsBuilder.getSuggestions (/Users/scott/.atom/packages/language-marko/src/autocomplete/SuggestionsBuilder.js:147:22)
    at Object.getSuggestions (/Users/scott/.atom/packages/language-marko/src/autocomplete/provider.js:26:46)
    at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/autocomplete-plus/lib/autocomplete-manager.js:325:56
    at Array.forEach (native)
    at AutocompleteManager.module.exports.AutocompleteManager.getSuggestionsFromProviders (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/autocomplete-plus/lib/autocomplete-manager.js:304:17)
    at AutocompleteManager.getSuggestionsFromProviders (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/autocomplete-plus/lib/autocomplete-manager.js:3:59)
    at AutocompleteManager.module.exports.AutocompleteManager.findSuggestions (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/autocomplete-plus/lib/autocomplete-manager.js:291:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/autocomplete-plus/lib/autocomplete-manager.js:3:59

Commands

Config

{
  "core": {
    "disabledPackages": [
      "wrap-guide",
      "selection-highlight",
      "multi-highlight-selected"
    ],
    "telemetryConsent": "limited",
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages

# User
atom-lupa, v0.7.25 (inactive)
autoclose-html, v0.23.0 (active)
chrome-color-picker, v0.8.0 (inactive)
csslint, v1.1.5 (active)
custom-folds, v1.9.1 (active)
emmet, v2.4.3 (active)
fold-comments, v0.6.0 (inactive)
highlight-selected, v0.11.2 (active)
hyperclick, v0.0.39 (active)
hyperclick-marko, v2.0.0 (active)
jslint, v1.5.1 (active)
language-marko, v2.0.10 (active)
linter, v1.11.18 (active)
linter-csslint, v1.3.3 (active)
turbo-javascript, v1.4.0 (inactive)
atom-dark-syntax, v0.27.0 (active)
atom-dark-ui, v0.52.0 (active)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (inactive)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (inactive)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.13.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.4 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (active)
metrics, v1.1.1 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (inactive)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.0 (active)
language-csharp, v0.12.1 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.46.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages
DylanPiercey commented 3 years ago

The plugin was reworked to use our Language Server implementation. This should be fixed now.