search

marko-js / cli

command-line tools for Marko
MIT License
95 stars 36 forks source link

@marko/serve - Route param syntax starting with colon is not allowed on Windows #177

Closed ghost closed 3 years ago

ghost commented 3 years ago

@marko/serve@2.1.1

Details

Windows does not allow file or directory names starting with a colon. This makes route params unusable on Windows.

Expected Behavior

Actual Behavior

Possible Fix

Sapper uses brackets in a similar fashion.

Additional Info ### Your Environment - Environment name and version (e.g. Chrome 39, node.js 5.4): - Operating System and version (desktop or mobile): - Link to your project: ### Steps to Reproduce 1. first... 2. 3. 4. ### Stack Trace
johnpage-agixis commented 3 years ago

Try cloning https://github.com/ryansolid/marko-hackernews on windows Git won't even checkout the main branch

error: invalid path 'src/pages/:stories/index.marko'
error: invalid path 'src/pages/stories/:id/index.marko'
error: invalid path 'src/pages/users/:id/index.marko'

Some reports say that cygwin git can checkout the files, but has trouble committing changes to them.

The problem comes from the fact that NTFS treats "file:name" as an alternate data stream called "data" of the file called "file".