search

marko-js / cli

command-line tools for Marko
MIT License
95 stars 36 forks source link

fix: add support for [id] naming for params #187

Closed DylanPiercey closed 3 years ago

DylanPiercey commented 3 years ago

Description

Updates the build command to switch from the folder/:id.marko naming convention for params to folder/[id].marko which works properly in windows. The existing colon convention has now been deprecated.

Resolves https://github.com/marko-js/cli/issues/177 Resolves https://github.com/marko-js/cli/issues/175 Resolves https://github.com/marko-js/marko/issues/1666

This PR also includes a fix where paths were not properly being normalized for windows.

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #187 (24bf61e) into main (d8c89d4) will increase coverage by 0.19%. The diff coverage is 94.11%.

:exclamation: Current head 24bf61e differs from pull request most recent head 6315289. Consider uploading reports for the commit 6315289 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   66.31%   66.51%   +0.19%     
==========================================
  Files          61       61              
  Lines        1707     1714       +7     
==========================================
+ Hits         1132     1140       +8     
+ Misses        575      574       -1
Impacted Files Coverage Δ
packages/build/src/util.js 90.75% <94.11%> (+1.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8c89d4...6315289. Read the comment docs.