search

marko-js / examples

55 stars 36 forks source link

rollup-express example results in error #27

Open piyushchauhan2011 opened 2 years ago

piyushchauhan2011 commented 2 years ago

After following the instructions from examples repository to try out rollup-express example, it results in js error and on the user interface, we are unable to interact with dynamic components. This happens in both dev and prod mode.

Screen Shot 2565-06-08 at 04 30 58 Screen Shot 2565-06-08 at 04 30 44
Screen Shot 2565-06-08 at 04 35 27
piyushchauhan2011 commented 2 years ago

I was wondering what can be done to try out rollup example?

DylanPiercey commented 2 years ago

@piyushchauhan2011 I just took a look into this one and it appears there were changes in recent versions of @rollup/plugin-node-resolve and @rollup/plugin-commonjs. I think the fix on our end is going to require some thinking.

If you're wanting to get started with Marko I'd recommend our Vite setup for now if you're not heart set on rollup. If you did wan't to go with rollup you'll have the best luck with pinning to previous releases of these:

    "@rollup/plugin-commonjs": "21.1.0",
    "@rollup/plugin-node-resolve": "13.2.1",
DylanPiercey commented 2 years ago

For future reference this is related: https://github.com/rollup/plugins/issues/1195

piyushchauhan2011 commented 2 years ago

Cool, no worries. I'll continue with the Vite setup for now 👍🏼