update vite-cloudflare example so it works

marko-js / examples

55 stars 36 forks source link

Closed JaderDias closed 2 years ago

JaderDias commented 2 years ago

before these changes there was a serious security issue with one of the imported libraries

undici 4.8.2 - 5.5.0 Severity: high ProxyAgent vulnerable to MITM - https://github.com/advisories/GHSA-pgw7-wx7w-2w33

and the latest wrangler cli tool couldn't find the output js file since it has changed its expectations about the format of the wrangler.toml file

linux-foundation-easycla[bot] commented 2 years ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: JaderDias (ed40b6b5bf04bebbe35ea599090186901d6584f3, e7ec6897cdaec732f79fb7690c39baca6815d990)

DylanPiercey commented 2 years ago

Thanks for the PR, could you link the security issue? Undici was only setup to be used in dev, so curious what the impact is.

JaderDias commented 2 years ago

@DylanPiercey All I know I got from npm audit

undici 4.8.2 - 5.5.0 Severity: high ProxyAgent vulnerable to MITM - https://github.com/advisories/GHSA-pgw7-wx7w-2w33

DylanPiercey commented 2 years ago

👍 looks good thanks!