marko-js / fastify

Render Marko templates in a Fastify application.
MIT License
10 stars 1 forks source link

Fix peer dependency for fastify #2

Closed haikyuu closed 3 years ago

haikyuu commented 3 years ago

This is happening in a newer version of npm and this only shows a warning in previous ones Latest fastify is a ^3. version

This is the error we get right now when doing an npm install or installing throufh marko cli

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: my-app@1.0.0
npm ERR! Found: fastify@undefined
npm ERR! node_modules/fastify
npm ERR!   fastify@"^4.14.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer fastify@"^4 || ^5" from @marko/fastify@1.0.1
npm ERR! node_modules/@marko/fastify
npm ERR!   @marko/fastify@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/ma/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/ma/.npm/_logs/2021-03-11T16_22_08_589Z-debug.log
codecov[bot] commented 3 years ago

Codecov Report

Merging #2 (2486fa6) into main (5e8c574) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           18        18           
  Branches         3         3           
=========================================
  Hits            18        18           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e8c574...dcd1456. Read the comment docs.

DylanPiercey commented 3 years ago

Ah, peerDependencies... The ^4 || ^5 was from when this was basically forked from `@marko/express. Good catch! Will release the fix right away.

DylanPiercey commented 3 years ago

Released as @marko/fastify@1.0.2

haikyuu commented 3 years ago

Thanks @DylanPiercey

haikyuu commented 3 years ago

It works fine now