search

marko-js / fastify

Render Marko templates in a Fastify application.
MIT License
10 stars 1 forks source link

Fix for issue#6 #7

Closed J-Hoh closed 2 years ago

J-Hoh commented 2 years ago

Fix for issue#6

Motivation and Context

This bypasses the normal .send(stream) format of fastify. Instead the template stream gets sent to the raw reply stream directly, fixing the issue described above.

Checklist:

J-Hoh commented 2 years ago

ok actually hold on before pulling, found another bug that happens somewhat randomly now. Headers sometimes arent sent before the raw stream. I'll report back when i got a solution

codecov[bot] commented 2 years ago

Codecov Report

Merging #7 (4b1b829) into main (971a7df) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           18        19    +1     
  Branches         3         3           
=========================================
+ Hits            18        19    +1
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 971a7df...4b1b829. Read the comment docs.

DylanPiercey commented 2 years ago

I think the work around we discussed in #6 is good enough for now. If we can come up with some better way to warn or automate this though I'd for sure be interested!