marko-js / htmljs-parser

An HTML parser recognizes content and string placeholders and allows JavaScript expressions as attribute values
MIT License
135 stars 20 forks source link

Fixed Code Example onOpenTagStart #137

Closed ThomasMcDonald closed 2 years ago

ThomasMcDonald commented 2 years ago

Description

onOpenTagStart was missing a comma

Motivation and Context

I wasn't able to copy/paste the example code and have it run first go.

Checklist:

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 98a3565d7caf5e0ee758ff00e1280567f0d30196

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (98a3565) into main (7d3bd75) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files          26       26           
  Lines         801      801           
  Branches      268      268           
=======================================
  Hits          738      738           
  Misses         48       48           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

DylanPiercey commented 2 years ago

Thanks @ThomasMcDonald !