marko-js / htmljs-parser

An HTML parser recognizes content and string placeholders and allows JavaScript expressions as attribute values
MIT License
135 stars 20 forks source link

fix: issue with escaped placeholder at end of tag #143

Closed DylanPiercey closed 1 year ago

DylanPiercey commented 1 year ago

Fix issue where and extra character was being consumed if an escaped placeholder was at the end of a tag.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 55fedd7312244125c573ddf567725e0074021942

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | htmljs-parser | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.16% // Head: 93.16% // No change to project coverage :thumbsup:

Coverage data is based on head (55fedd7) compared to base (76d00ee). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #143 +/- ## ======================================= Coverage 93.16% 93.16% ======================================= Files 26 26 Lines 1272 1272 Branches 288 288 ======================================= Hits 1185 1185 Misses 56 56 Partials 31 31 ``` | [Impacted Files](https://codecov.io/gh/marko-js/htmljs-parser/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js) | Coverage Δ | | |---|---|---| | [src/states/PLACEHOLDER.ts](https://codecov.io/gh/marko-js/htmljs-parser/pull/143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js#diff-c3JjL3N0YXRlcy9QTEFDRUhPTERFUi50cw==) | `97.61% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.