marko-js / htmljs-parser

An HTML parser recognizes content and string placeholders and allows JavaScript expressions as attribute values
MIT License
135 stars 20 forks source link

fix: scriptlet block with semi-colon #148

Closed DylanPiercey closed 1 year ago

DylanPiercey commented 1 year ago

Fix issue with semi-colon after a block scriptlet.

eg

$ {
  console.log("hi");
};
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: f6bf7149199f32f510915e56376e867e1f46be13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | htmljs-parser | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.23% // Head: 93.09% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (f6bf714) compared to base (e864b4b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #148 +/- ## ========================================== - Coverage 93.23% 93.09% -0.14% ========================================== Files 26 26 Lines 1271 1275 +4 Branches 287 289 +2 ========================================== + Hits 1185 1187 +2 - Misses 55 57 +2 Partials 31 31 ``` | [Impacted Files](https://codecov.io/gh/marko-js/htmljs-parser/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js) | Coverage Δ | | |---|---|---| | [src/states/INLINE\_SCRIPT.ts](https://codecov.io/gh/marko-js/htmljs-parser/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js#diff-c3JjL3N0YXRlcy9JTkxJTkVfU0NSSVBULnRz) | `100.00% <100.00%> (ø)` | | | [src/core/Parser.ts](https://codecov.io/gh/marko-js/htmljs-parser/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js#diff-c3JjL2NvcmUvUGFyc2VyLnRz) | `91.30% <0.00%> (-1.45%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.