search

marko-js / htmljs-parser

An HTML parser recognizes content and string placeholders and allows JavaScript expressions as attribute values
MIT License
135 stars 20 forks source link

fix: ensure type args directly follow tag name #152

Closed DylanPiercey closed 1 year ago

DylanPiercey commented 1 year ago

Improve handling ambiguity with tag type args vs type params. Type args must now always be directly adjacent the tag name, otherwise it will become type params.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c8ecdbee83841e9815d629f928c1900811ea718c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | htmljs-parser | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.41% // Head: 93.40% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (c8ecdbe) compared to base (210427c). Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== - Coverage 93.41% 93.40% -0.02% ========================================== Files 26 26 Lines 1276 1274 -2 Branches 289 288 -1 ========================================== - Hits 1192 1190 -2 - Misses 53 54 +1 + Partials 31 30 -1 ``` | [Impacted Files](https://codecov.io/gh/marko-js/htmljs-parser/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js) | Coverage Δ | | |---|---|---| | [src/states/OPEN\_TAG.ts](https://codecov.io/gh/marko-js/htmljs-parser/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js#diff-c3JjL3N0YXRlcy9PUEVOX1RBRy50cw==) | `91.34% <88.88%> (+0.39%)` | :arrow_up: | | [src/states/ATTRIBUTE.ts](https://codecov.io/gh/marko-js/htmljs-parser/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js#diff-c3JjL3N0YXRlcy9BVFRSSUJVVEUudHM=) | `94.52% <0.00%> (-0.69%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.