search

marko-js / htmljs-parser

An HTML parser recognizes content and string placeholders and allows JavaScript expressions as attribute values
MIT License
135 stars 20 forks source link

fix: parsed text placeholders should enter the text state on close qu… #161

Closed DylanPiercey closed 1 year ago

DylanPiercey commented 1 year ago

Description

Resolves https://github.com/marko-js/marko/issues/1912

Checklist:

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 6bb6ba4a98df053220de012b8c797bf81e4444a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | htmljs-parser | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d8de146) 93.65% compared to head (6bb6ba4) 93.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## ======================================= Coverage 93.65% 93.66% ======================================= Files 27 27 Lines 1293 1294 +1 Branches 293 293 ======================================= + Hits 1211 1212 +1 Misses 53 53 Partials 29 29 ``` | [Impacted Files](https://codecov.io/gh/marko-js/htmljs-parser/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js) | Coverage Δ | | |---|---|---| | [src/states/PARSED\_STRING.ts](https://codecov.io/gh/marko-js/htmljs-parser/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js#diff-c3JjL3N0YXRlcy9QQVJTRURfU1RSSU5HLnRz) | `90.00% <100.00%> (+1.11%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marko-js)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.