marko-js / language-server

Marko autocomplete, intellisense and editor support.
MIT License
38 stars 8 forks source link

Non-zero exit code when there are no type errors #215

Closed vwong closed 9 months ago

vwong commented 9 months ago

@marko/type-check@1.0.0

Details

Incorrect exit code causes CI to fail. With no code changes, previous version returned exit code zero, but new 1.0.0 version returns exit code 1.

Expected Behavior

Same as @marko/type-check@0.0.18: when there are type errors, process should exit with non-zero exit code. When there are no type errors, process should exit with zero exit code.

Actual Behavior

Process exits with code 1, even when code passes typecheck - confirmed with @marko/type-check@0.0.18

Your Environment

NodeJS 18.18.0, Mac OS 13.6